[INC-300] baton-github: optimize Grants() for org Resource #97
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| bag, page, err := parsePageToken(pToken.Token, resource.Id) | ||
| if err != nil { | ||
| return nil, "", nil, err | ||
| } |
There was a problem hiding this comment.
I want to use bag. But looks like we need to push resourceTypes to bag. bag.push(resourceTypes)
How to handle pagination nicely? in this case.
There was a problem hiding this comment.
The resource.Id should contain the resource type, right? You should be able to push page tokens for different resources and resource types, then pop stuff off and switch based on the resource type. See https://github.com/ConductorOne/baton-microsoft-entra/blob/main/pkg/connector/enterprise_applications.go#L267 for an example.
There was a problem hiding this comment.
yes need to use pagination bag
There was a problem hiding this comment.
retested it.
it's a little confusing. I push admin and member as resourceTypeId, but it works.
Thanks!
| if rId == orgRoleAdmin { | ||
| rv = append(rv, o.orgRoleGrant(orgRoleMember, resource, ur.Id, user.GetID())) | ||
| } | ||
| rv = append(rv, o.orgRoleGrant(rId, resource, ur.Id, user.GetID())) |
There was a problem hiding this comment.
Bug: Pending Memberships Included in Grants
The optimization removed the check for pending organization memberships. Previously, users with pending invitations were explicitly skipped. The new code, using role-filtered ListMembers() API calls, no longer performs this check, leading to pending members being incorrectly included in grants.
Locations (1)
Uh oh!
There was an error while loading. Please reload this page.